diff options
author | Denton Liu <liu.denton@gmail.com> | 2019-12-20 10:16:01 -0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-12-20 11:30:45 -0800 |
commit | 9291e6329ef3333f9447b0b4cdec0607e00c39cf (patch) | |
tree | 484ba485c296361cb6492e0ee0ab5e514192f9b4 /xdiff/xemit.h | |
parent | t1507: stop losing return codes of git commands (diff) | |
download | tgif-9291e6329ef3333f9447b0b4cdec0607e00c39cf.tar.xz |
t1507: run commands within test_expect_success
The expected test style is to have all commands tested within a
test_expect_success block. Move the generation of the 'expect' text into
their corresponding blocks. While we're at it, insert a second
`commit=$(git rev-parse HEAD)` into the next test case so that it's
clear where $commit is coming from.
The biggest advantage of doing this is that we now check the return code
of `git rev-parse HEAD` so we can catch it in case it fails.
This patch is best viewed with `--color-moved --ignore-all-space`.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'xdiff/xemit.h')
0 files changed, 0 insertions, 0 deletions