diff options
| author |  Stefan Beller <sbeller@google.com> | 2016-02-29 13:57:06 -0800 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2016-03-01 09:42:01 -0800 |
| commit | 2a73b3dad09ef162eb5917e9e0d01d7c306f6b35 (patch) | |
| tree | d3566e6ddadb7f1cdeb0a520b125e9cbac164e77 /xdiff/xdiffi.c | |
| parent | submodules: allow parallel fetching, add tests and documentation (diff) | |
| download | tgif-2a73b3dad09ef162eb5917e9e0d01d7c306f6b35.tar.xz | |
run-command: do not pass child process data into callbacks
The expected way to pass data into the callback is to pass them via
the customizable callback pointer. The error reporting in
default_{start_failure, task_finished} is not user friendly enough, that
we want to encourage using the child data for such purposes.
Furthermore the struct child data is cleaned by the run-command API,
before we access them in the callbacks, leading to use-after-free
situations.
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'xdiff/xdiffi.c')
0 files changed, 0 insertions, 0 deletions