summaryrefslogtreecommitdiff
path: root/version.c
diff options
context:
space:
mode:
authorLibravatar Nguyễn Thái Ngọc Duy <pclouds@gmail.com>2018-09-18 19:31:59 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-09-21 09:17:02 -0700
commit84d938b732242e81ec68647994070eb7c34d061f (patch)
tree2179095e9c8dcf8872129f962dd4a15204005693 /version.c
parentGit 2.15.2 (diff)
downloadtgif-84d938b732242e81ec68647994070eb7c34d061f.tar.xz
add: do not accept pathspec magic 'attr'
Commit b0db704652 (pathspec: allow querying for attributes - 2017-03-13) adds new pathspec magic 'attr' but only with match_pathspec(). "git add" has some pathspec related code that still does not know about 'attr' and will bail out: $ git add ':(attr:foo)' fatal: BUG:dir.c:1584: unsupported magic 40 A better solution would be making this code support 'attr'. But I don't know how much work is needed (I'm not familiar with this new magic). For now, let's simply reject this magic with a friendlier message: $ git add ':(attr:foo)' fatal: :(attr:foo): pathspec magic not supported by this command: 'attr' Update t6135 so that the expected error message is from the "graceful" rejection codepath, not "oops, we were supposed to reject the request to trigger this magic" codepath. Reported-by: smaudet@sebastianaudet.com Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'version.c')
0 files changed, 0 insertions, 0 deletions