diff options
| author |  Denton Liu <liu.denton@gmail.com> | 2019-04-29 04:28:14 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-05-05 15:20:06 +0900 |
| commit | 554544276a604c144df45efcb060c80aa322088c (patch) | |
| tree | ce55b3dc9ca47c326991ecfc06a2b1103f60be3a /vcs-svn | |
| parent | The fifth batch (diff) | |
| download | tgif-554544276a604c144df45efcb060c80aa322088c.tar.xz | |
*.[ch]: remove extern from function declarations using spatch
There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.
This was the Coccinelle patch used:
@@
type T;
identifier f;
@@
- extern
T f(...);
and it was run with:
$ git ls-files \*.{c,h} |
grep -v ^compat/ |
xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place
Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'vcs-svn')
| -rw-r--r-- | vcs-svn/sliding_window.h | 2 | ||||
| -rw-r--r-- | vcs-svn/svndiff.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/vcs-svn/sliding_window.h b/vcs-svn/sliding_window.h index 189c32d84c..a7fc0999cb 100644 --- a/vcs-svn/sliding_window.h +++ b/vcs-svn/sliding_window.h @@ -13,6 +13,6 @@ struct sliding_view { #define SLIDING_VIEW_INIT(input, len) { (input), 0, 0, (len), STRBUF_INIT } -extern int move_window(struct sliding_view *view, off_t off, size_t width); +int move_window(struct sliding_view *view, off_t off, size_t width); #endif diff --git a/vcs-svn/svndiff.h b/vcs-svn/svndiff.h index 10a2cbc40e..023799a05c 100644 --- a/vcs-svn/svndiff.h +++ b/vcs-svn/svndiff.h @@ -4,7 +4,7 @@ struct line_buffer; struct sliding_view; -extern int svndiff0_apply(struct line_buffer *delta, off_t delta_len, +int svndiff0_apply(struct line_buffer *delta, off_t delta_len, struct sliding_view *preimage, FILE *postimage); #endif |