summaryrefslogtreecommitdiff
path: root/vcs-svn/svndump.h
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2015-09-24 17:06:44 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-09-25 10:18:18 -0700
commitc3bb0ac796c21490f478914441526817e4685606 (patch)
tree59e6bba21c971116ee5afdf3de2020d54d03d553 /vcs-svn/svndump.h
parentuse xsnprintf for generating git object headers (diff)
downloadtgif-c3bb0ac796c21490f478914441526817e4685606.tar.xz
find_short_object_filename: convert sprintf to xsnprintf
We use sprintf() to format some hex data into a buffer. The buffer is clearly long enough, and using snprintf here is not necessary. And in fact, it does not really make anything easier to audit, as the size we feed to snprintf accounts for the magic extra 42 bytes found in each alt->name field of struct alternate_object_database (which is there exactly to do this formatting). Still, it is nice to remove an sprintf call and replace it with an xsnprintf and explanatory comment, which makes it easier to audit the code base for overflows. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'vcs-svn/svndump.h')
0 files changed, 0 insertions, 0 deletions