summaryrefslogtreecommitdiff
path: root/urlmatch.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2020-01-30 04:53:38 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-01-30 13:55:30 -0800
commit8dd40c0472a8f51f4fba4b8fd28dc3e9421cd7d7 (patch)
treea1b1355b6075426f066cfca9c4ad0a4843c9398a /urlmatch.c
parentwalker_fetch(): avoid raw array length computation (diff)
downloadtgif-8dd40c0472a8f51f4fba4b8fd28dc3e9421cd7d7.tar.xz
traverse_trees(): use stack array for name entries
We heap-allocate our arrays of name_entry structs, etc, with one entry per tree we're asked to traverse. The code does a raw multiplication in the xmalloc() call, which I find when auditing for integer overflows during allocation. We could "fix" this by using ALLOC_ARRAY() instead. But as it turns out, the maximum size of these arrays is limited at compile time: - merge_trees() always passes in 3 trees - unpack_trees() and its brethren never pass in more than MAX_UNPACK_TREES So we can simplify even further by just using a stack array and bounding it with MAX_UNPACK_TREES. There should be no concern with overflowing the stack, since MAX_UNPACK_TREES is only 8 and the structs themselves are small. Note that since we're replacing xcalloc(), we have to move one of the NULL initializations into a loop. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'urlmatch.c')
0 files changed, 0 insertions, 0 deletions