summaryrefslogtreecommitdiff
path: root/upload-pack.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2019-06-20 03:40:50 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-06-20 09:23:53 -0700
commit6d79e5ecb342586466e0321487f08f17cbccb2bb (patch)
treedaa6ac9a5e30c8d5f6a5a32433a469836891f5fe /upload-pack.c
parentThe second batch (diff)
downloadtgif-6d79e5ecb342586466e0321487f08f17cbccb2bb.tar.xz
describe: fix accidental oid/hash type-punning
The find_commit_name() function passes an object_id.hash as the key of a hashmap. That ends up in commit_name_neq(), which then feeds it to oideq(). Which means we should actually be the whole "struct object_id". It works anyway because pointers to the two are interchangeable. And because we're going through a layer of void pointers, the compiler doesn't notice the type mismatch. But it's worth cleaning up (especially since once we switch away from sha1hash() on the same line, accessing the hash member will look doubly out of place). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'upload-pack.c')
0 files changed, 0 insertions, 0 deletions