diff options
author | Jonathan Tan <jonathantanmy@google.com> | 2019-05-22 13:08:22 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-05-28 11:01:07 -0700 |
commit | 5b204b7df3ed7e97040d40db9d7c31a0a645af15 (patch) | |
tree | 08a296c472b4d725cf946d08c05732e6124d364d /trace2 | |
parent | clone: send server options when using protocol v2 (diff) | |
download | tgif-5b204b7df3ed7e97040d40db9d7c31a0a645af15.tar.xz |
fetch-pack: send server options after command
Currently, if any server options are specified during a protocol v2
fetch, server options will be sent before "command=fetch". Write server
options to the request buffer in send_fetch_request() so that the
components of the request are sent in the correct order.
The protocol documentation states that the command must come first. The
Git server implementation in serve.c (see process_request() in that
file) tolerates any order of command and capability, which is perhaps
why we haven't noticed this. This was noticed when testing against a
JGit server implementation, which follows the documentation in this
regard.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'trace2')
0 files changed, 0 insertions, 0 deletions