diff options
author | Taylor Blau <me@ttaylorr.com> | 2021-03-19 11:40:52 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-03-19 11:19:29 -0700 |
commit | 14e7b8344f0b7349b914331c0aff18f73faf03da (patch) | |
tree | b932cdda92418e4a86a8b286da615450756f0a05 /trace2.h | |
parent | builtin/repack.c: reword comment around pack-objects flags (diff) | |
download | tgif-14e7b8344f0b7349b914331c0aff18f73faf03da.tar.xz |
builtin/pack-objects.c: ignore missing links with --stdin-packs
When 'git pack-objects --stdin-packs' encounters a commit in a pack, it
marks it as a starting point of a best-effort reachability traversal
that is used to populate the name-hash of the objects listed in the
given packs.
The traversal expects that it should be able to walk the ancestors of
all commits in a pack without issue. Ordinarily this is the case, but it
is possible to having missing parents from an unreachable part of the
repository. In that case, we'd consider any missing objects in the
unreachable portion of the graph to be junk.
This should be handled gracefully: since the traversal is best-effort
(i.e., we don't strictly need to fill in all of the name-hash fields),
we should simply ignore any missing links.
This patch does that (by setting the 'ignore_missing_links' bit on the
rev_info struct), and ensures we don't regress in the future by adding a
test which demonstrates this case.
It is a little over-eager, since it will also ignore missing links in
reachable parts of the packs (which would indicate a corrupted
repository), but '--stdin-packs' is explicitly *not* about reachability.
So this step isn't making anything worse for a repository which contains
packs missing reachable objects (since we never drop objects with
'--stdin-packs').
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'trace2.h')
0 files changed, 0 insertions, 0 deletions