diff options
author | Shawn O. Pearce <spearce@spearce.org> | 2006-12-24 00:47:23 -0500 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2006-12-29 11:36:45 -0800 |
commit | c4712e4553f13d87d655325a57538f299402d457 (patch) | |
tree | d09717f9d9a811d36ae5572b131a5b40e1dfcdcf /trace.c | |
parent | Release pack windows before reporting out of memory. (diff) | |
download | tgif-c4712e4553f13d87d655325a57538f299402d457.tar.xz |
Replace mmap with xmmap, better handling MAP_FAILED.
In some cases we did not even bother to check the return value of
mmap() and just assume it worked. This is bad, because if we are
out of virtual address space the kernel returned MAP_FAILED and we
would attempt to dereference that address, segfaulting without any
real error output to the user.
We are replacing all calls to mmap() with xmmap() and moving all
MAP_FAILED checking into that single location. If a mmap call
fails we try to release enough least-recently-used pack windows
to possibly succeed, then retry the mmap() attempt. If we cannot
mmap even after releasing pack memory then we die() as none of our
callers have any reasonable recovery strategy for a failed mmap.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'trace.c')
0 files changed, 0 insertions, 0 deletions