summaryrefslogtreecommitdiff
path: root/t
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2013-06-04 09:50:12 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2013-06-04 13:36:54 -0700
commitf445500e4dd79ad0c4f6cf1c4949f01f155142f7 (patch)
tree792240be533e8032a274c0ae4b22e3a1173148b5 /t
parentsha1_file: trivial style cleanup (diff)
downloadtgif-f445500e4dd79ad0c4f6cf1c4949f01f155142f7.tar.xz
t/README: test_must_fail is for testing Git
When a test wants to make sure there is no <string> in an output file, we should just say "! grep string output". "test_must_fail" is there only to test Git command and catch unusual deaths we know about (e.g. segv) as an error, not as an expected failure. "test_must_fail grep string output" is unnecessary, as we are not making sure the system binaries do not dump core or anything like that. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
-rw-r--r--t/README3
1 files changed, 3 insertions, 0 deletions
diff --git a/t/README b/t/README
index e669bb31b9..35b3c5c2fa 100644
--- a/t/README
+++ b/t/README
@@ -324,6 +324,9 @@ Don't:
use 'test_must_fail git cmd'. This will signal a failure if git
dies in an unexpected way (e.g. segfault).
+ On the other hand, don't use test_must_fail for running regular
+ platform commands; just use '! cmd'.
+
- use perl without spelling it as "$PERL_PATH". This is to help our
friends on Windows where the platform Perl often adds CR before
the end of line, and they bundle Git with a version of Perl that