summaryrefslogtreecommitdiff
path: root/t
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2019-11-15 04:06:01 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-11-18 10:46:30 +0900
commitf28bceca7545727064b4e9a73ac7e9acf08b54b4 (patch)
tree03d7adb934a864a8d173b39d3a3f11766f33d1ac /t
parentt9502: pass along all arguments in xss helper (diff)
downloadtgif-f28bceca7545727064b4e9a73ac7e9acf08b54b4.tar.xz
t/gitweb-lib.sh: drop confusing quotes
Some variables assignments in gitweb_run() look like this: FOO=""$1"" The extra quotes aren't doing anything. Each set opens and closes an empty string, and $1 is actually outside of any double-quotes (which is OK, because variable assignment does not do whitespace splitting on the expanded value). Let's drop them, as they're simply confusing. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
-rw-r--r--t/gitweb-lib.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index 006d2a8152..130c7ed64f 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -58,8 +58,8 @@ gitweb_run () {
GATEWAY_INTERFACE='CGI/1.1'
HTTP_ACCEPT='*/*'
REQUEST_METHOD='GET'
- QUERY_STRING=""$1""
- PATH_INFO=""$2""
+ QUERY_STRING=$1
+ PATH_INFO=$2
export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \
QUERY_STRING PATH_INFO