diff options
| author |  Erik Faye-Lund <kusmabite@gmail.com> | 2011-04-10 22:54:18 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2011-04-11 14:10:06 -0700 |
| commit | e96c19c50fb0807570b85cb5b8aae6dfcfa9b9ec (patch) | |
| tree | 27fa8b42fe693cb101c83c5269f763f1e68ab7de /t | |
| parent | strbuf: make sure buffer is zero-terminated (diff) | |
| download | tgif-e96c19c50fb0807570b85cb5b8aae6dfcfa9b9ec.tar.xz | |
config: support values longer than 1023 bytes
parse_value in config.c has a static buffer of 1024 bytes that it
parse the value into. This can sometimes be a problem when a
config file contains very long values.
It's particularly amusing that git-config already is able to write
such files, so it should probably be able to read them as well.
Fix this by using a strbuf instead of a fixed-size buffer.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t1303-wacky-config.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t1303-wacky-config.sh b/t/t1303-wacky-config.sh index 080117c6bc..46103a1591 100755 --- a/t/t1303-wacky-config.sh +++ b/t/t1303-wacky-config.sh @@ -44,7 +44,7 @@ LONG_VALUE=$(printf "x%01021dx a" 7) test_expect_success 'do not crash on special long config line' ' setup && git config section.key "$LONG_VALUE" && - check section.key "fatal: bad config file line 2 in .git/config" + check section.key "$LONG_VALUE" ' test_done |