summaryrefslogtreecommitdiff
path: root/t
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2017-01-16 16:33:29 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-01-17 14:24:33 -0800
commitc6c7b16d23a4cb6af26acee865c2ade1a3822bef (patch)
treebb5f8e6c2b63ecbab751c3feab361db7f68325d9 /t
parentfsck: prepare dummy objects for --connectivity-check (diff)
downloadtgif-c6c7b16d23a4cb6af26acee865c2ade1a3822bef.tar.xz
fsck: tighten error-checks of "git fsck <head>"
Instead of checking reachability from the refs, you can ask fsck to check from a particular set of heads. However, the error checking here is quite lax. In particular: 1. It claims lookup_object() will report an error, which is not true. It only does a hash lookup, and the user has no clue that their argument was skipped. 2. When either the name or sha1 cannot be resolved, we continue to exit with a successful error code, even though we didn't check what the user asked us to. This patch fixes both of these cases. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
-rwxr-xr-xt/t1450-fsck.sh5
1 files changed, 5 insertions, 0 deletions
diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
index 4d1c3ba664..6b6db62c4e 100755
--- a/t/t1450-fsck.sh
+++ b/t/t1450-fsck.sh
@@ -611,4 +611,9 @@ test_expect_success 'fsck notices dangling objects' '
)
'
+test_expect_success 'fsck $name notices bogus $name' '
+ test_must_fail git fsck bogus &&
+ test_must_fail git fsck $_z40
+'
+
test_done