diff options
| author |  Jonathan Tan <jonathantanmy@google.com> | 2016-10-21 10:55:02 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2016-10-21 11:48:35 -0700 |
| commit | c463a6b28023dd3ad7ad4542147e20c27dbc83d6 (patch) | |
| tree | 86aef84aedfa56c587b2480081f3b442ce3b2e3d /t | |
| parent | trailer: allow non-trailers in trailer block (diff) | |
| download | tgif-c463a6b28023dd3ad7ad4542147e20c27dbc83d6.tar.xz | |
trailer: forbid leading whitespace in trailers
Currently, interpret-trailers allows leading whitespace in trailer
lines. This leads to false positives, especially for quoted lines or
bullet lists.
Forbid leading whitespace in trailers.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t7513-interpret-trailers.sh | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/t/t7513-interpret-trailers.sh b/t/t7513-interpret-trailers.sh index 003e90f8cf..3d94b3a2f7 100755 --- a/t/t7513-interpret-trailers.sh +++ b/t/t7513-interpret-trailers.sh @@ -241,6 +241,21 @@ test_expect_success 'with non-trailer lines only' ' test_cmp expected actual ' +test_expect_success 'line with leading whitespace is not trailer' ' + q_to_tab >patch <<-\EOF && + + Qtoken: value + EOF + q_to_tab >expected <<-\EOF && + + Qtoken: value + + token: value + EOF + git interpret-trailers --trailer "token: value" patch >actual && + test_cmp expected actual +' + test_expect_success 'with config setup' ' git config trailer.ack.key "Acked-by: " && cat >expected <<-\EOF && |