summaryrefslogtreecommitdiff
path: root/t
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2018-10-30 19:23:38 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-10-31 13:05:26 +0900
commit98f425b453870cdb20b4bf8daa29f52af8e59866 (patch)
treee9ec3be96b91298e849218623f36f56ba7c13c94 /t
parentcheck_stream_sha1(): handle input underflow (diff)
downloadtgif-98f425b453870cdb20b4bf8daa29f52af8e59866.tar.xz
cat-file: handle streaming failures consistently
There are three ways to convince cat-file to stream a blob: - cat-file -p $blob - cat-file blob $blob - echo $batch | cat-file --batch In the first two, we simply exit with the error code of streaw_blob_to_fd(). That means that an error will cause us to exit with "-1" (which we try to avoid) without printing any kind of error message (which is confusing to the user). Instead, let's match the third case, which calls die() on an error. Unfortunately we cannot be more specific, as stream_blob_to_fd() does not tell us whether the problem was on reading (e.g., a corrupt object) or on writing (e.g., ENOSPC). That might be an opportunity for future work, but for now we will at least exit with a sane message and exit code. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
0 files changed, 0 insertions, 0 deletions