diff options
| author |  René Scharfe <l.s.r@web.de> | 2017-10-03 16:36:40 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2017-10-04 13:41:49 +0900 |
| commit | 97487ea11a2c68934927e515616c133e543a72ce (patch) | |
| tree | d10311cf0a99e338d4a43f8bd67e524fc81ee148 /t | |
| parent | ref-filter: use QSORT_S in ref_array_sort() (diff) | |
| download | tgif-97487ea11a2c68934927e515616c133e543a72ce.tar.xz | |
test-stringlist: avoid buffer underrun when sorting nothing
Check if the strbuf containing data to sort is empty before attempting
to trim a trailing newline character.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rw-r--r-- | t/helper/test-string-list.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/helper/test-string-list.c b/t/helper/test-string-list.c index c502fa16d3..829ec3d7d2 100644 --- a/t/helper/test-string-list.c +++ b/t/helper/test-string-list.c @@ -108,7 +108,7 @@ int cmd_main(int argc, const char **argv) * Split by newline, but don't create a string_list item * for the empty string after the last separator. */ - if (sb.buf[sb.len - 1] == '\n') + if (sb.len && sb.buf[sb.len - 1] == '\n') strbuf_setlen(&sb, sb.len - 1); string_list_split_in_place(&list, sb.buf, '\n', -1); |