diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2017-10-23 14:37:21 +0900 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-10-23 14:37:22 +0900 |
| commit | 96c6bb566ee5354a1b07530a94d3f85055e46032 (patch) | |
| tree | 675b4ea93a5c4ffd9db000608d23a794f6cf7d4e /t | |
| parent | Merge branch 'rj/no-sign-compare' into maint (diff) | |
| parent | read_pack_header: handle signed/unsigned comparison in read result (diff) | |
| download | tgif-96c6bb566ee5354a1b07530a94d3f85055e46032.tar.xz | |
Merge branch 'jk/write-in-full-fix' into maint
Many codepaths did not diagnose write failures correctly when disks
go full, due to their misuse of write_in_full() helper function,
which have been corrected.
* jk/write-in-full-fix:
read_pack_header: handle signed/unsigned comparison in read result
config: flip return value of store_write_*()
notes-merge: use ssize_t for write_in_full() return value
pkt-line: check write_in_full() errors against "< 0"
convert less-trivial versions of "write_in_full() != len"
avoid "write_in_full(fd, buf, len) != len" pattern
get-tar-commit-id: check write_in_full() return against 0
config: avoid "write_in_full(fd, buf, len) < len" pattern
Diffstat (limited to 't')
| -rw-r--r-- | t/helper/test-delta.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/helper/test-delta.c b/t/helper/test-delta.c index 59937dc1be..591730adc4 100644 --- a/t/helper/test-delta.c +++ b/t/helper/test-delta.c @@ -69,7 +69,7 @@ int cmd_main(int argc, const char **argv) } fd = open (argv[4], O_WRONLY|O_CREAT|O_TRUNC, 0666); - if (fd < 0 || write_in_full(fd, out_buf, out_size) != out_size) { + if (fd < 0 || write_in_full(fd, out_buf, out_size) < 0) { perror(argv[4]); return 1; } |