diff options
| author |  Brandon Casey <drafnel@gmail.com> | 2010-06-21 12:37:13 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2010-06-21 11:11:11 -0700 |
| commit | 832ac79edf0e0e9108f5da5b10b496a227667f40 (patch) | |
| tree | 2ff2767e63ea9ec8cff14aee1f698446de9de0ac /t | |
| parent | grep -O: allow optional argument specifying the pager (or editor) (diff) | |
| download | tgif-832ac79edf0e0e9108f5da5b10b496a227667f40.tar.xz | |
t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression
Regular expressions matched by 'expr' have an implicit '^' at the beginning
of them and so are anchored to the beginning of the string. Using the '^'
character to mean "match at the beginning", is redundant and could produce
the wrong result if 'expr' implementations interpret the '^' as a literal
'^'. Additionally, GNU expr 5.97 complains like this:
expr: warning: unportable BRE: `^[a-z][a-z]*$': using `^' as the first character of the basic regular expression is not portable; it is being ignored
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rw-r--r-- | t/lib-pager.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/lib-pager.sh b/t/lib-pager.sh index f8c6025876..ba03eab14f 100644 --- a/t/lib-pager.sh +++ b/t/lib-pager.sh @@ -9,7 +9,7 @@ test_expect_success 'determine default pager' ' test -n "$less" ' -if expr "$less" : '^[a-z][a-z]*$' >/dev/null +if expr "$less" : '[a-z][a-z]*$' >/dev/null then test_set_prereq SIMPLEPAGER fi |