diff options
| author |  Jeff King <peff@peff.net> | 2019-04-11 09:48:14 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-04-12 13:34:17 +0900 |
| commit | 73a5faf0176548640784090190bb2448cf1708aa (patch) | |
| tree | 8cd8928c8eacbd48f96173991077c0e7c5e461d6 /t | |
| parent | Git 2.20.1 (diff) | |
| download | tgif-73a5faf0176548640784090190bb2448cf1708aa.tar.xz | |
test-prio-queue: use xmalloc
test-prio-queue.c doesn't check the return value of malloc, and could
segfault.
It's unlikely for this to matter in practice; it's a small allocation,
and this code isn't even installed alongside the rest of Git. But let's
use xmalloc(), which makes auditing for other accidental uses of bare
malloc() easier.
Reported-by: 王健强 <jianqiang.wang@securitygossip.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rw-r--r-- | t/helper/test-prio-queue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/helper/test-prio-queue.c b/t/helper/test-prio-queue.c index 5bc9c46ea5..f4028442e3 100644 --- a/t/helper/test-prio-queue.c +++ b/t/helper/test-prio-queue.c @@ -40,7 +40,7 @@ int cmd__prio_queue(int argc, const char **argv) } else if (!strcmp(*argv, "stack")) { pq.compare = NULL; } else { - int *v = malloc(sizeof(*v)); + int *v = xmalloc(sizeof(*v)); *v = atoi(*argv); prio_queue_put(&pq, v); } |