diff options
author | Ramkumar Ramachandra <artagnon@gmail.com> | 2013-03-31 18:40:40 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-03-31 21:30:09 -0700 |
commit | 622bc9309155b05af1a0d85bfb643bf6280eba35 (patch) | |
tree | b774d7625db651eb891026c8c385dc86171bfabd /t | |
parent | Merge branch 'maint-1.8.1' into maint (diff) | |
download | tgif-622bc9309155b05af1a0d85bfb643bf6280eba35.tar.xz |
send-email: use "return;" not "return undef;" on error codepaths
All the callers of "ask", "extract_valid_address", and "validate_patch"
subroutines assign the return values from them to a single scalar:
$var = subr(...);
and "return undef;" in these subroutine can safely be turned into a
simpler "return;". Doing so will also future-proof a new caller that
mistakenly does this:
@foo = ask(...);
if (@foo) { ... we got an answer ... } else { ... we did not ... }
Note that we leave "return undef;" in validate_address on purpose,
even though Perlcritic may complain. The primary "return" site of
the function returns whatever is in the scalar variable $address, so
it is pointless to change only the other "return undef;" to "return".
The caller must be prepared to see an array with a single undef as
the return value from this subroutine anyway.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
0 files changed, 0 insertions, 0 deletions