diff options
| author |  Eric Sunshine <sunshine@sunshineco.com> | 2020-12-20 16:27:40 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-12-22 13:45:36 -0800 |
| commit | 5bc12c11ccdd3126cf04cf08cf59bf3c204f7f2a (patch) | |
| tree | d6fb85ac6b3f0e8f8e4ed500a2d1e4db3a3e6e0e /t | |
| parent | t/perf: fix test_export() failure with BSD `sed` (diff) | |
| download | tgif-5bc12c11ccdd3126cf04cf08cf59bf3c204f7f2a.tar.xz | |
t/perf: avoid unnecessary test_export() recursion
test_export() has been self-recursive since its inception even though a
simple for-loop would have served just as well to append its arguments
to the `test_export_` variable separated by the pipe character "|".
Recently `test_export_` was changed instead to a space-separated list of
tokens to be exported, an operation which can be accomplished via a
single simple assignment, with no need for looping or recursion.
Therefore, simplify the implementation.
While at it, take advantage of the fact that variable names to be
exported are shell identifiers, thus won't be composed of special
characters or whitespace, thus simple a `$*` can be used rather than
magical `"$@"`.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rw-r--r-- | t/perf/perf-lib.sh | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index 22d727cef8..e385c6896f 100644 --- a/t/perf/perf-lib.sh +++ b/t/perf/perf-lib.sh @@ -147,10 +147,7 @@ test_run_perf_ () { "$GTIME" -f "%E %U %S" -o test_time.$i "$SHELL" -c ' . '"$TEST_DIRECTORY"/test-lib-functions.sh' test_export () { - [ $# != 0 ] || return 0 - test_export_="$test_export_ $1" - shift - test_export "$@" + test_export_="$test_export_ $*" } '"$1"' ret=$? |