summaryrefslogtreecommitdiff
path: root/t
diff options
context:
space:
mode:
authorLibravatar Alexander Gavrilov <angavrilov@gmail.com>2008-11-09 18:06:07 +0300
committerLibravatar Paul Mackerras <paulus@samba.org>2008-11-13 22:20:25 +1100
commit590915dab8aaf464f5819c4ccec7941c3490e3ce (patch)
tree006f050d93b3c4d3e5a9e4aa72f983331b38e9db /t
parentgitk: Fix transient windows on Win32 and MacOS (diff)
downloadtgif-590915dab8aaf464f5819c4ccec7941c3490e3ce.tar.xz
gitk: Fix commit encoding support
This commit fixes two problems with commit encodings: 1) git-log actually uses i18n.logoutputencoding to generate its output, and falls back to i18n.commitencoding only when that option is not set. Thus, gitk should use its value to read the results, if available. 2) The readcommit function did not process encodings at all. This led to randomly appearing misconverted commits if the commit encoding differed from the current locale. Now commit messages should be displayed correctly, except when logoutputencoding is set to an encoding that cannot represent charecters in the message. For example, it is impossible to convert Japanese characters from Shift-JIS to CP-1251 (although the reverse conversion works). The reason for using git log to read the commit and then getting Tcl to convert its output is that is essentially what happens in the normal path through getcommitlines, hence there is less chance for unintended differences in how commits are processed in getcommitlines and do_readcommit. Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com> Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 't')
0 files changed, 0 insertions, 0 deletions