diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2013-11-06 10:00:57 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-11-06 11:03:33 -0800 |
| commit | 4ef8d1dd03d3b8adf81b4b81b2231128e3591f36 (patch) | |
| tree | 102db9c3334ecb998e7b7d3a64ca711a6df4b17e /t | |
| parent | t5570: Update for clone-progress-to-stderr branch (diff) | |
| download | tgif-4ef8d1dd03d3b8adf81b4b81b2231128e3591f36.tar.xz | |
sha1_loose_object_info(): do not return success on missing object
Since 052fe5ea (sha1_loose_object_info: make type lookup optional,
2013-07-12), sha1_loose_object_info() returns happily without
checking if the object in question exists, which is not what the the
caller sha1_object_info_extended() expects; the caller does not even
bother checking the existence of the object itself.
Noticed-by: Sven Brauch <svenbrauch@googlemail.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t1006-cat-file.sh | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh index 4e911fb43d..558f0f5292 100755 --- a/t/t1006-cat-file.sh +++ b/t/t1006-cat-file.sh @@ -179,6 +179,12 @@ test_expect_success "--batch-check for an emtpy line" ' test " missing" = "$(echo | git cat-file --batch-check)" ' +test_expect_success 'empty --batch-check notices missing object' ' + echo "$_z40 missing" >expect && + echo "$_z40" | git cat-file --batch-check="" >actual && + test_cmp expect actual +' + batch_input="$hello_sha1 $commit_sha1 $tag_sha1 |