diff options
author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2017-11-01 18:10:25 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-11-02 11:19:41 +0900 |
commit | 3f944424ac899fb6705e7463d937c5ed581da207 (patch) | |
tree | dff5b2ff2f2a913a3c430e95d3ae93ba9cdd502b /t | |
parent | Git 2.15 (diff) | |
download | tgif-3f944424ac899fb6705e7463d937c5ed581da207.tar.xz |
mingw: add experimental feature to redirect standard handles
Particularly when calling Git from applications, such as Visual Studio's
Team Explorer, it is important that stdin/stdout/stderr are closed
properly. However, when spawning processes on Windows, those handles
must be marked as inheritable if we want to use them, but that flag is a
global flag and may very well be used by other spawned processes which
then do not know to close those handles.
Let's introduce a set of environment variables (GIT_REDIRECT_STDIN and
friends) that specify paths to files, or even better, named pipes (which
are similar to Unix sockets) and that are used by the spawned Git
process. This helps work around above-mentioned issue: those named
pipes will be opened in a non-inheritable way upon startup, and no
handles are passed around (and therefore no inherited handles need to be
closed by any spawned child).
This feature shipped with Git for Windows (marked as experimental) since
v2.11.0(2), so it has seen some serious testing in the meantime.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
-rwxr-xr-x | t/t0001-init.sh | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/t/t0001-init.sh b/t/t0001-init.sh index 86c1a51654..0fd2fc4538 100755 --- a/t/t0001-init.sh +++ b/t/t0001-init.sh @@ -453,4 +453,10 @@ test_expect_success 're-init from a linked worktree' ' ) ' +test_expect_success MINGW 'redirect std handles' ' + GIT_REDIRECT_STDOUT=output.txt git rev-parse --git-dir && + test .git = "$(cat output.txt)" && + test -z "$(GIT_REDIRECT_STDOUT=off git rev-parse --git-dir)" +' + test_done |