diff options
| author |  Jeff King <peff@peff.net> | 2015-12-20 02:27:18 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2015-12-21 12:03:03 -0800 |
| commit | 3e4068ed90fd3c6f24303560113aae6dbb758699 (patch) | |
| tree | 961357513efbe7e6985801d5d024c39e17b03d0e /t | |
| parent | Git 2.4.10 (diff) | |
| download | tgif-3e4068ed90fd3c6f24303560113aae6dbb758699.tar.xz | |
symbolic-ref: propagate error code from create_symref()
If create_symref() fails, git-symbolic-ref will still exit
with code 0, and our caller has no idea that the command did
nothing.
This appears to have been broken since the beginning of time
(e.g., it is not a regression where create_symref() stopped
calling die() or something similar).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t1401-symbolic-ref.sh | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh index 36378b0e3f..e9219a9303 100755 --- a/t/t1401-symbolic-ref.sh +++ b/t/t1401-symbolic-ref.sh @@ -63,4 +63,10 @@ test_expect_success 'symbolic-ref fails to delete real ref' ' ' reset_to_sane +test_expect_success 'symbolic-ref reports failure in exit code' ' + test_when_finished "rm -f .git/HEAD.lock" && + >.git/HEAD.lock && + test_must_fail git symbolic-ref HEAD refs/heads/whatever +' + test_done |