summaryrefslogtreecommitdiff
path: root/t
diff options
context:
space:
mode:
authorLibravatar Nguyễn Thái Ngọc Duy <pclouds@gmail.com>2018-01-24 16:30:20 +0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-01-24 12:40:13 -0800
commit2523c4be855af84460e70ab5c8375534f8cefed5 (patch)
treec1867f2356eb89c2c88e286d1c20903e92378f39 /t
parentstatus: add a failing test showing a core.untrackedCache bug (diff)
downloadtgif-2523c4be855af84460e70ab5c8375534f8cefed5.tar.xz
dir.c: avoid stat() in valid_cached_dir()
stat() may follow a symlink and return stat data of the link's target instead of the link itself. We are concerned about the link itself. It's kind of hard to demonstrate the bug. I think when path->buf is a symlink, we most likely find that its target's stat data does not match our cached one, which means we ignore the cache and fall back to slow path. This is performance issue, not correctness (though we could still catch it by verifying test-dump-untracked-cache. The less unlikely case is, link target stat data matches the cached version and we incorrectly go fast path, ignoring real data on disk. A test for this may involve manipulating stat data, which may be not portable. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
0 files changed, 0 insertions, 0 deletions