diff options
author | Jeff King <peff@peff.net> | 2017-02-14 01:04:17 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-02-14 11:26:37 -0800 |
commit | 20d6421cae23d33fa153a9251360298ff7f1ce0a (patch) | |
tree | 3224c79d889ecaec395df449eaa5fde30ef8867d /t | |
parent | grep: do not unnecessarily query repo for "--" (diff) | |
download | tgif-20d6421cae23d33fa153a9251360298ff7f1ce0a.tar.xz |
grep: re-order rev-parsing loop
We loop over the arguments, but every branch of the loop
hits either a "continue" or a "break". Surely we can make
this simpler.
The final conditional is:
if (arg is a rev) {
... handle rev ...
continue;
}
break;
We can rewrite this as:
if (arg is not a rev)
break;
... handle rev ...
That makes the flow a little bit simpler, and will make
things much easier to follow when we add more logic in
future patches.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
0 files changed, 0 insertions, 0 deletions