diff options
author | Johannes Sixt <j6t@kdbg.org> | 2016-01-25 22:47:56 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2016-01-25 14:04:14 -0800 |
commit | e7d5ce816579723150c341116737fb51d8e33eb3 (patch) | |
tree | 0fc4691447f583325531a032afebf0f468d40f66 /t/t9820-git-p4-editor-handling.sh | |
parent | t0060: loosen overly strict expectations (diff) | |
download | tgif-e7d5ce816579723150c341116737fb51d8e33eb3.tar.xz |
mingw: avoid linking to the C library's isalpha()
The implementation of mingw_skip_dos_drive_prefix() calls isalpha() via
has_dos_drive_prefix(). Since the definition occurs long before isalpha()
is defined in git-compat-util.h, my build environment reports:
CC alloc.o
In file included from git-compat-util.h:186,
from cache.h:4,
from alloc.c:12:
compat/mingw.h: In function 'mingw_skip_dos_drive_prefix':
compat/mingw.h:365: warning: implicit declaration of function 'isalpha'
Dscho does not see a similar warning in his build and suspects that
ctype.h is included somehow behind the scenes. This implies that his build
links to the C library's isalpha() and does not use git's isalpha().
To fix both the warning in my build and the inconsistency in Dscho's
build, move the function definition to mingw.c. Then it picks up git's
isalpha() because git-compat-util.h is included at the top of the file.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9820-git-p4-editor-handling.sh')
0 files changed, 0 insertions, 0 deletions