diff options
| author |  Denton Liu <liu.denton@gmail.com> | 2020-04-20 04:54:45 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-04-20 13:30:55 -0700 |
| commit | 546f352638fd4fd7e517e8c6e74e229825e9afab (patch) | |
| tree | 8cac81a81595ffb052de04801a1b347a0d2ad9fc /t/t9819-git-p4-case-folding.sh | |
| parent | t9164: use test_must_fail only on git commands (diff) | |
| download | tgif-546f352638fd4fd7e517e8c6e74e229825e9afab.tar.xz | |
t9819: don't use test_must_fail with p4
We were using `test_must_fail p4` to test that the p4 command failed as
expected. However, test_must_fail() is used to ensure that commands fail
in an expected way, not due to something like a segv. Since we are not
in the business of verifying the sanity of the external world, replace
`test_must_fail p4` with `! p4` and assume that the `p4` command does
not die unexpectedly.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9819-git-p4-case-folding.sh')
| -rwxr-xr-x | t/t9819-git-p4-case-folding.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-folding.sh index 600ce1e0b0..b4d93f0c17 100755 --- a/t/t9819-git-p4-case-folding.sh +++ b/t/t9819-git-p4-case-folding.sh @@ -30,7 +30,7 @@ test_expect_success 'Check p4 is in case-folding mode' ' cd "$cli" && >lc/FILE.TXT && p4 add lc/FILE.TXT && - test_must_fail p4 submit -d "Cannot add file differing only in case" lc/FILE.TXT + ! p4 submit -d "Cannot add file differing only in case" lc/FILE.TXT ) ' |