summaryrefslogtreecommitdiff
path: root/t/t9800-git-p4-basic.sh
diff options
context:
space:
mode:
authorLibravatar Elijah Newren <newren@gmail.com>2020-04-01 04:17:40 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-04-01 11:10:38 -0700
commit2df179d3dfeb431cc3030ac44e79b136debf1fd9 (patch)
tree1aeb43092c98e57af442b881b6a9bcfa67371eb8 /t/t9800-git-p4-basic.sh
parentdir: fix broken comment (diff)
downloadtgif-2df179d3dfeb431cc3030ac44e79b136debf1fd9.tar.xz
dir: fix confusion based on variable tense
Despite having contributed several fixes in this area, I have for months (years?) assumed that the "exclude" variable was a directive; this caused me to think of it as a different mode we operate in and left me confused as I tried to build up a mental model around why we'd need such a directive. I mostly tried to ignore it while focusing on the pieces I was trying to understand. Then I finally traced this variable all back to a call to is_excluded(), meaning it was actually functioning as an adjective. In particular, it was a checked property ("Does this path match a rule in .gitignore?"), rather than a mode passed in from the caller. Change the variable name to match the part of speech used by the function called to define it, which will hopefully make these bits of code slightly clearer to the next reader. Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9800-git-p4-basic.sh')
0 files changed, 0 insertions, 0 deletions