diff options
author | Jeff King <peff@peff.net> | 2015-09-03 04:24:09 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-09-03 15:18:12 -0700 |
commit | 1c9b659d9837fa2bd6ab21edaae94d19c20ac216 (patch) | |
tree | e93fd6cd3682f1b4f74abd201adc55e8048f571b /t/t9602 | |
parent | Git 2.6-rc0 (diff) | |
download | tgif-1c9b659d9837fa2bd6ab21edaae94d19c20ac216.tar.xz |
pack-protocol: clarify LF-handling in PKT-LINE()
The spec is very inconsistent about which PKT-LINE() parts
of the grammar include a LF. On top of that, the code is not
consistent, either (e.g., send-pack does not put newlines
into the ref-update commands it sends).
Let's make explicit the long-standing expectation that we
generally expect pkt-lines to end in a newline, but that
receivers should be lenient. This makes the spec consistent,
and matches what git already does (though it does not always
fulfill the SHOULD).
We do make an exception for the push-cert, where the
receiving code is currently a bit pickier. This is a
reasonable way to be, as the data needs to be byte-for-byte
compatible with what was signed. We _could_ make up some
rules about signing a canonicalized version including
newlines, but that would require a code change, and is out
of scope for this patch.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9602')
0 files changed, 0 insertions, 0 deletions