diff options
author | Jeff King <peff@peff.net> | 2015-05-28 03:56:15 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-05-28 11:33:18 -0700 |
commit | 1570856b510e3722a3620063e7ba209106b75857 (patch) | |
tree | 80086c5f7772e866f92bffc6da99482c8b099a46 /t/t9153 | |
parent | config.c: fix mmap leak when writing config (diff) | |
download | tgif-1570856b510e3722a3620063e7ba209106b75857.tar.xz |
config.c: avoid xmmap error messages
The config-writing code uses xmmap to map the existing
config file, which will die if the map fails. This has two
downsides:
1. The error message is not very helpful, as it lacks any
context about the file we are mapping:
$ mkdir foo
$ git config --file=foo some.key value
fatal: Out of memory? mmap failed: No such device
2. We normally do not die in this code path; instead, we'd
rather report the error and return an appropriate exit
status (which is part of the public interface
documented in git-config.1).
This patch introduces a "gentle" form of xmmap which lets us
produce our own error message. We do not want to use mmap
directly, because we would like to use the other
compatibility elements of xmmap (e.g., handling 0-length
maps portably).
The end result is:
$ git.compile config --file=foo some.key value
error: unable to mmap 'foo': No such device
$ echo $?
3
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9153')
0 files changed, 0 insertions, 0 deletions