diff options
| author |  SZEDER Gábor <szeder.dev@gmail.com> | 2018-08-19 23:57:23 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-08-21 11:48:31 -0700 |
| commit | f0dc593a95877298ba6fa9d29e5c779832ad5894 (patch) | |
| tree | 681d125d75ad101f756e5aa8da69e8b8547393b4 /t/t8010-cat-file-filters.sh | |
| parent | tests: use 'test_must_be_empty' instead of '! test -s' (diff) | |
| download | tgif-f0dc593a95877298ba6fa9d29e5c779832ad5894.tar.xz | |
tests: use 'test_must_be_empty' instead of 'test ! -s'
Using 'test_must_be_empty' is preferable to 'test ! -s', because it
gives a helpful error message if the given file is unexpectedly no
empty, while the latter remains completely silent. Furthermore, it
also catches cases when the given file unexpectedly does not exist at
all.
This patch was created by:
sed -i -e 's/test ! -s/test_must_be_empty/' t[0-9]*.sh
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t8010-cat-file-filters.sh')
| -rwxr-xr-x | t/t8010-cat-file-filters.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t8010-cat-file-filters.sh b/t/t8010-cat-file-filters.sh index 0f86c19174..31de4b64dc 100755 --- a/t/t8010-cat-file-filters.sh +++ b/t/t8010-cat-file-filters.sh @@ -47,7 +47,7 @@ test_expect_success 'cat-file --textconv --path=<path> works' ' test_expect_success '--path=<path> complains without --textconv/--filters' ' sha1=$(git rev-parse -q --verify HEAD:world.txt) && test_must_fail git cat-file --path=hello.txt blob $sha1 >actual 2>err && - test ! -s actual && + test_must_be_empty actual && grep "path.*needs.*filters" err ' |