diff options
author | Stefan Beller <stefanbeller@googlemail.com> | 2013-07-18 00:09:42 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-07-17 18:10:51 -0700 |
commit | 8e92e8f2422a5805916e5e14c6bebfd82467e044 (patch) | |
tree | 1fb03d5b600b219ae20ccd258fa61d99b9240229 /t/t8003-blame-corner-cases.sh | |
parent | Git 1.8.0.3 (diff) | |
download | tgif-8e92e8f2422a5805916e5e14c6bebfd82467e044.tar.xz |
parse_object_buffer: correct freeing the buffer
If we exit early in the function parse_object_buffer, we did not
write to *eaten_p. Then the calling function parse_object, which looks
like the following with respect to the eaten variable, cannot rely on a
proper value set in eaten, hence the freeing of the buffer depends
on random values in memory.
struct object *parse_object(const unsigned char *sha1)
{
int eaten;
...
obj = parse_object_buffer(sha1, type, size, buffer, &eaten);
if (!eaten)
free(buffer);
}
This change makes sure, the buffer freeing condition is deterministic.
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t8003-blame-corner-cases.sh')
0 files changed, 0 insertions, 0 deletions