summaryrefslogtreecommitdiff
path: root/t/t7503-pre-commit-hook.sh
diff options
context:
space:
mode:
authorLibravatar Nguyễn Thái Ngọc Duy <pclouds@gmail.com>2018-11-10 06:16:11 +0100
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-11-12 14:47:09 +0900
commit9440b831ad5b1750b65fa3f1d0b99179ab317c76 (patch)
tree64f2fa307e00fef20bc714ca6ba06fcca1b65b79 /t/t7503-pre-commit-hook.sh
parentrepack: mark more strings for translation (diff)
downloadtgif-9440b831ad5b1750b65fa3f1d0b99179ab317c76.tar.xz
parse-options: replace opterror() with optname()
Introduce optname() that does the early half of original opterror() to come up with the name of the option reported back to the user, and use it to kill opterror(). The callers of opterror() now directly call error() using the string returned by opterror() instead. There are a few issues with opterror() - it tries to assemble an English sentence from pieces. This is not great for translators because we give them pieces instead of a full sentence. - It's a wrapper around error() and needs some hack to let the compiler know it always returns -1. - Since it takes a string instead of printf format, one call site has to assemble the string manually before passing to it. Using error() directly solves the second and third problems. It kind helps the first problem as well because "%s does foo" does give a translator a full sentence in a sense and let them reorder if needed. But it has limitations, if the subject part has to change based on the rest of the sentence, that language is screwed. This is also why I try to avoid calling optname() when 'flags' is known in advance. Mark of these strings for translation as well while at there. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t7503-pre-commit-hook.sh')
0 files changed, 0 insertions, 0 deletions