diff options
author | Jonathan Nieder <jrnieder@gmail.com> | 2011-03-26 00:15:10 -0500 |
---|---|---|
committer | Jonathan Nieder <jrnieder@gmail.com> | 2011-03-26 00:15:10 -0500 |
commit | e7d04ee147dcbe6af1fa1d2147466696e2be31bc (patch) | |
tree | ae39bba6d863b5185d08ce46106dff032ecee0e6 /t/t7401-submodule-summary.sh | |
parent | Merge branch 'db/length-as-hash' into svn-fe (diff) | |
download | tgif-e7d04ee147dcbe6af1fa1d2147466696e2be31bc.tar.xz |
vcs-svn: make reading of properties binary-safe
svn-fe errors out on revision 59151 of the ASF repository:
fatal: invalid dump: unexpected end of file
The proximate cause is a property with an embedded NUL character.
Previously such anomalies were ignored but commit c9d1c8ba
(2010-12-28) introduced a check strlen(val) == len to avoid reading
uninitialized data when a property list ends early and unfortunately
this test does not distinguish between "foo" followed by EOF and the
string "foo\0bar\0baz".
Fix it by using buffer_read_binary to read to a strbuf and checking
the actual length read. Most consumers of properties still use
C-style strings, so in practice an author or log message with embedded
NULs will be truncated, but a least this way svn-fe won't error out
(fixing the regression).
Reported-by: David Barr <david.barr@cordelta.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Diffstat (limited to 't/t7401-submodule-summary.sh')
0 files changed, 0 insertions, 0 deletions