diff options
author | Elijah Newren <newren@gmail.com> | 2021-05-27 04:53:56 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-05-27 14:02:37 +0900 |
commit | 906fc557b70b2b2995785c9b37e212d2f86b469e (patch) | |
tree | aae98ad6bb236082101b55fa3617b94da11204a1 /t/t6600-test-reach.sh | |
parent | dir: update stale description of treat_directory() (diff) | |
download | tgif-906fc557b70b2b2995785c9b37e212d2f86b469e.tar.xz |
dir: introduce readdir_skip_dot_and_dotdot() helper
Many places in the code were doing
while ((d = readdir(dir)) != NULL) {
if (is_dot_or_dotdot(d->d_name))
continue;
...process d...
}
Introduce a readdir_skip_dot_and_dotdot() helper to make that a one-liner:
while ((d = readdir_skip_dot_and_dotdot(dir)) != NULL) {
...process d...
}
This helper particularly simplifies checks for empty directories.
Also use this helper in read_cached_dir() so that our statistics are
consistent across platforms. (In other words, read_cached_dir() should
have been using is_dot_or_dotdot() and skipping such entries, but did
not and left it to treat_path() to detect and mark such entries as
path_none.)
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t6600-test-reach.sh')
0 files changed, 0 insertions, 0 deletions