diff options
author | Junio C Hamano <gitster@pobox.com> | 2007-07-17 22:58:28 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2007-07-18 00:53:09 -0700 |
commit | fa2e71c9e794c43634670b62d1b4bf58d1ae7e60 (patch) | |
tree | 76c39fedea03cac74bbfd31bb373f40cd3fe3e3c /t/t6025-merge-symlinks.sh | |
parent | GIT 1.5.2.4 (diff) | |
download | tgif-fa2e71c9e794c43634670b62d1b4bf58d1ae7e60.tar.xz |
Do not expect unlink(2) to fail on a directory.
When "git checkout-index" checks out path A/B/C, it makes sure A
and A/B are truly directories; if there is a regular file or
symlink at A, we prefer to remove it.
We used to do this by catching an error return from mkdir(2),
and on EEXIST did unlink(2), and when it succeeded, tried
another mkdir(2).
Thomas Glanzmann found out the above does not work on Solaris
for a root user, as unlink(2) was so old fashioned there that it
allowed to unlink a directory.
As pointed out, this still doesn't guarantee that git won't call
"unlink()" on a directory (race conditions etc), but that's
fundamentally true (there is no "funlink()" like there is
"fstat()"), and besides, that is in no way git-specific (ie it's
true of any application that gets run as root).
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t6025-merge-symlinks.sh')
0 files changed, 0 insertions, 0 deletions