diff options
author | brian m. carlson <sandals@crustytoothpaste.net> | 2021-04-26 01:02:55 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-04-27 16:31:38 +0900 |
commit | 5a6dce70d7bb12ee2bc7926254c5b6741b91ac5f (patch) | |
tree | a4350b3f781b36cda38fc645a5eb54b161eb4536 /t/t6016-rev-list-graph-simplify-history.sh | |
parent | builtin/pack-redundant: avoid casting buffers to struct object_id (diff) | |
download | tgif-5a6dce70d7bb12ee2bc7926254c5b6741b91ac5f.tar.xz |
hash: set, copy, and use algo field in struct object_id
Now that struct object_id has an algorithm field, we should populate it.
This will allow us to handle object IDs in any supported algorithm and
distinguish between them. Ensure that the field is written whenever we
write an object ID by storing it explicitly every time we write an
object. Set values for the empty blob and tree values as well.
In addition, use the algorithm field to compare object IDs. Note that
because we zero-initialize struct object_id in many places throughout
the codebase, we default to the default algorithm in cases where the
algorithm field is zero rather than explicitly initialize all of those
locations.
This leads to a branch on every comparison, but the alternative is to
compare the entire buffer each time and padding the buffer for SHA-1.
That alternative ranges up to 3.9% worse than this approach on the perf
t0001, t1450, and t1451.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t6016-rev-list-graph-simplify-history.sh')
0 files changed, 0 insertions, 0 deletions