diff options
author | Jens Lindstrom <jl@opera.com> | 2013-10-22 15:36:02 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-10-23 09:07:09 -0700 |
commit | 37cb1dd671e5e22cee363f98637a5a58f16be054 (patch) | |
tree | acf25b123b55691bac708b8fa0e5cd3e9c7b75fe /t/t6009-rev-list-parent.sh | |
parent | git-merge: document the -S option (diff) | |
download | tgif-37cb1dd671e5e22cee363f98637a5a58f16be054.tar.xz |
Clear fd after closing to avoid double-close error
In send_pack(), clear the fd passed to pack_objects() by setting
it to -1, since pack_objects() closes the fd (via a call to
run_command()). Likewise, in get_pack(), clear the fd passed to
run_command().
Not doing so risks having git_transport_push(), caller of
send_pack(), closing the fd again, possibly incorrectly closing
some other open file; or similarly with fetch_refs_from_pack(),
indirect caller of get_pack().
Signed-off-by: Jens Lindström <jl@opera.com>
Acked-by: Jeff King <peff@peff.net>
Acked-by: Duy Nguyen <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t6009-rev-list-parent.sh')
0 files changed, 0 insertions, 0 deletions