diff options
author | Christian Couder <chriscool@tuxfamily.org> | 2013-12-01 08:49:15 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-12-05 14:12:52 -0800 |
commit | 3fb5aead2971c6181dbf143295c427175b8bf082 (patch) | |
tree | a7baac05b8fa928301947cf00cd34018429fc6e7 /t/t6003-rev-list-topo-order.sh | |
parent | environment: normalize use of prefixcmp() by removing " != 0" (diff) | |
download | tgif-3fb5aead2971c6181dbf143295c427175b8bf082.tar.xz |
builtin/remote: remove postfixcmp() and use suffixcmp() instead
Commit 8cc5b290 (git merge -X<option>, 25 Nov 2009) introduced
suffixcmp() with nearly the same implementation as postfixcmp()
that already existed since commit 211c8968 (Make git-remote a
builtin, 29 Feb 2008).
The only difference between the two implementations is that,
when the string is smaller than the suffix, one implementation
returns 1 while the other one returns -1.
But, as postfixcmp() is only used to compare for equality, the
distinction does not matter and does not affect the correctness of
this patch.
As postfixcmp() has always been static in builtin/remote.c
and is used nowhere else, it makes more sense to remove it
and use suffixcmp() instead in builtin/remote.c, rather than
to remove suffixcmp().
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t6003-rev-list-topo-order.sh')
0 files changed, 0 insertions, 0 deletions