summaryrefslogtreecommitdiff
path: root/t/t6001-rev-list-graft.sh
diff options
context:
space:
mode:
authorLibravatar Martin Ågren <martin.agren@gmail.com>2017-08-02 21:40:53 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-08-03 11:08:10 -0700
commitde121ffe57fd14334c24f0ac51dbc6828a3bc315 (patch)
tree45a030612c07a076aeb793b4a6e2edca4c78b033 /t/t6001-rev-list-graft.sh
parentt7006: add tests for how git tag paginates (diff)
downloadtgif-de121ffe57fd14334c24f0ac51dbc6828a3bc315.tar.xz
tag: respect `pager.tag` in list-mode only
Using, e.g., `git -c pager.tag tag -a new-tag` results in errors such as "Vim: Warning: Output is not to a terminal" and a garbled terminal. Someone who makes use of both `git tag -a` and `git tag -l` will probably not set `pager.tag`, so that `git tag -a` will actually work, at the cost of not paging output of `git tag -l`. Use the mechanisms introduced in two earlier patches to ignore `pager.tag` in git.c and let the `git tag` builtin handle it on its own. Only respect `pager.tag` when running in list-mode. There is a window between where the pager is started before and after this patch. This means that early errors can behave slightly different before and after this patch. Since operation-parsing has to happen inside this window, this can be seen with `git -c pager.tag="echo pager is used" tag -l --unknown-option`. This change in paging-behavior should be acceptable since it only affects erroneous usages. Update the documentation and update tests. If an alias is used to run `git tag -a`, then `pager.tag` will still be respected. Document this known breakage. It will be fixed in a later commit. Add a similar test for `-l`, which works. Noticed-by: Anatoly Borodin <anatoly.borodin@gmail.com> Suggested-by: Jeff King <peff@peff.net> Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t6001-rev-list-graft.sh')
0 files changed, 0 insertions, 0 deletions