diff options
author | Paolo Bonzini <bonzini@gnu.org> | 2008-08-27 17:20:35 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2008-08-29 00:14:29 -0700 |
commit | 0cfeed2e1d320cc76c434e0bfc26d90065754e46 (patch) | |
tree | 6d97516c7eff97cc960288e0930552d75ad54394 /t/t6001-rev-list-graft.sh | |
parent | Document gitk --argscmd flag. (diff) | |
download | tgif-0cfeed2e1d320cc76c434e0bfc26d90065754e46.tar.xz |
make git-shell paranoid about closed stdin/stdout/stderr
It is in general unsafe to start a program with one or more of file
descriptors 0/1/2 closed. Karl Chen for example noticed that stat_command
does this in order to rename a pipe file descriptor to 0:
dup2(from, 0);
close(from);
... but if stdin was closed (for example) from == 0, so that
dup2(0, 0);
close(0);
just ends up closing the pipe. Another extremely rare but nasty problem
would occur if an "important" file ends up in file descriptor 2, and is
corrupted by a call to die().
Fixing this in git was considered to be overkill, so this patch works
around it only for git-shell. The fix is simply to open all the "low"
descriptors to /dev/null in main.
Signed-off-by: Paolo Bonzini <bonzini@gnu.org>
Acked-by: Stephen R. van den Berg <srb@cuci.nl>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t6001-rev-list-graft.sh')
0 files changed, 0 insertions, 0 deletions