diff options
author | Eric Sunshine <sunshine@sunshineco.com> | 2021-12-13 01:30:56 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-12-13 14:15:29 -0800 |
commit | 22597af97d67660fb3f0dba538a1f02b1ba94243 (patch) | |
tree | 6950a948a7fd5ab9aa11dd5297c5b0143d62f555 /t/t5812-proto-disable-http.sh | |
parent | chainlint.sed: make here-doc "<<-" operator recognition more POSIX-like (diff) | |
download | tgif-22597af97d67660fb3f0dba538a1f02b1ba94243.tar.xz |
chainlint.sed: don't mistake `<< word` in string as here-doc operator
Tighten here-doc recognition to prevent it from being fooled by text
which looks like a here-doc operator but happens merely to be the
content of a string, such as this real-world case from t7201:
echo "<<<<<<< ours" &&
echo ourside &&
echo "=======" &&
echo theirside &&
echo ">>>>>>> theirs"
This problem went unnoticed because chainlint.sed is not a real parser,
but rather applies heuristics to pretend to understand shell code. In
this case, it saw what it thought was a here-doc operator (`<< ours`),
and fell off the end of the test looking for the closing tag "ours"
which it never found, thus swallowed the remainder of the test without
checking it for &&-chain breakage.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5812-proto-disable-http.sh')
0 files changed, 0 insertions, 0 deletions