summaryrefslogtreecommitdiff
path: root/t/t5612-clone-refspec.sh
diff options
context:
space:
mode:
authorLibravatar Thomas Gummerer <t.gummerer@gmail.com>2018-03-19 23:21:56 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-03-20 09:08:34 -0700
commitd319bb18b1bd3e0b7269b44b9bae5db99dfbb7dd (patch)
tree34d339f61dff6d0b93f05c97410ccd84353a3e81 /t/t5612-clone-refspec.sh
parentstash push: avoid printing errors (diff)
downloadtgif-d319bb18b1bd3e0b7269b44b9bae5db99dfbb7dd.tar.xz
stash push -u: don't create empty stash
When introducing the stash push feature, and thus allowing users to pass in a pathspec to limit the files that would get stashed in df6bba0937 ("stash: teach 'push' (and 'create_stash') to honor pathspec", 2017-02-28), this developer missed one place where the pathspec should be passed in. Namely in the call to the 'untracked_files()' function in the 'no_changes()' function. This resulted in 'git stash push -u -- <non-existant>' creating an empty stash when there are untracked files in the repository other that don't match the pathspec. As 'git stash' never creates empty stashes, this behaviour is wrong and confusing for users. Instead it should just show a message "No local changes to save", and not create a stash. Luckily the 'untracked_files()' function already correctly respects pathspecs that are passed to it, so the fix is simply to pass the pathspec along to the function. Reported-by: Marc Strapetz <marc.strapetz@syntevo.com> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5612-clone-refspec.sh')
0 files changed, 0 insertions, 0 deletions