diff options
author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2011-11-13 17:22:15 +0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2011-12-05 16:21:06 -0800 |
commit | d5a35c114ab6b4337a1c7598bf75c331d94ee092 (patch) | |
tree | 675d14129b5e8e7b06210e37e1b8dbd147ab9e09 /t/t5541-http-push.sh | |
parent | Convert many resolve_ref() calls to read_ref*() and ref_exists() (diff) | |
download | tgif-d5a35c114ab6b4337a1c7598bf75c331d94ee092.tar.xz |
Copy resolve_ref() return value for longer use
resolve_ref() may return a pointer to a static buffer. Callers that
use this value longer than a couple of statements should copy the
value to avoid some hidden resolve_ref() call that may change the
static buffer's value.
The bug found by Tony Wang <wwwjfy@gmail.com> in builtin/merge.c
demonstrates this. The first call is in cmd_merge()
branch = resolve_ref("HEAD", head_sha1, 0, &flag);
Then deep in lookup_commit_or_die() a few lines after, resolve_ref()
may be called again and destroy "branch".
lookup_commit_or_die
lookup_commit_reference
lookup_commit_reference_gently
parse_object
lookup_replace_object
do_lookup_replace_object
prepare_replace_object
for_each_replace_ref
do_for_each_ref
get_loose_refs
get_ref_dir
get_ref_dir
resolve_ref
All call sites are checked and made sure that xstrdup() is called if
the value should be saved.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5541-http-push.sh')
0 files changed, 0 insertions, 0 deletions