diff options
author | Martin Ågren <martin.agren@gmail.com> | 2017-08-07 20:20:45 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-08-07 13:27:20 -0700 |
commit | a81383badc50633fe459d8d2d10ee7af6c00abb7 (patch) | |
tree | 026e87d227914a758d8891d98398512961907f6c /t/t5540-http-push-webdav.sh | |
parent | Git 2.12 (diff) | |
download | tgif-a81383badc50633fe459d8d2d10ee7af6c00abb7.tar.xz |
Doc/git-{push,send-pack}: correct --sign= to --signed=
Since we're about to touch the behavior of --signed=, do this as a
preparatory step.
The documentation mentions --sign=, and it works. But that's just
because it's an unambiguous abbreviation of --signed, which is how it is
actually implemented. This was added in commit 30261094 ("push: support
signing pushes iff the server supports it", 2015-08-19). Back when that
series was developed [1] [2], there were suggestions about both --sign=
and --signed=. The final implementation settled on --signed=, but some
of the documentation and commit messages ended up using --sign=.
The option is referred to as --signed= in Documentation/config.txt
(under push.gpgSign).
One could argue that we have promised --sign for two years now, so we
should implement it as an alias for --signed. (Then we might also
deprecate the latter, something which was considered already then.) That
would be a slightly more intrusive change.
This minor issue would only be a problem once we want to implement some
other option --signfoo, but the earlier we do this step, the better.
[1] v1-thread:
https://public-inbox.org/git/1439492451-11233-1-git-send-email-dborowitz@google.com/T/#u
[2] v2-thread:
https://public-inbox.org/git/1439998007-28719-1-git-send-email-dborowitz@google.com/T/#m6533a6c4707a30b0d81e86169ff8559460cbf6eb
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5540-http-push-webdav.sh')
0 files changed, 0 insertions, 0 deletions