diff options
author | Elia Pinto <gitter.spiros@gmail.com> | 2016-01-04 10:10:46 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2016-01-04 13:44:17 -0800 |
commit | 752f505cf3e993003a854ecb1b6c08af8e40450e (patch) | |
tree | 2b741bf9329911d5429e74c95f8803a6695c72d1 /t/t5538-push-shallow.sh | |
parent | t/t5537-fetch-shallow.sh: use the $( ... ) construct for command substitution (diff) | |
download | tgif-752f505cf3e993003a854ecb1b6c08af8e40450e.tar.xz |
t/t5538-push-shallow.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5538-push-shallow.sh')
-rwxr-xr-x | t/t5538-push-shallow.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t5538-push-shallow.sh b/t/t5538-push-shallow.sh index ceee95b8a4..ecbf84d21c 100755 --- a/t/t5538-push-shallow.sh +++ b/t/t5538-push-shallow.sh @@ -104,7 +104,7 @@ EOF ' test_expect_success 'push from full to shallow' ' - ! git --git-dir=shallow2/.git cat-file blob `echo 1|git hash-object --stdin` && + ! git --git-dir=shallow2/.git cat-file blob $(echo 1|git hash-object --stdin) && commit 1 && git push shallow2/.git +master:refs/remotes/top/master && ( @@ -117,7 +117,7 @@ test_expect_success 'push from full to shallow' ' 3 EOF test_cmp expect actual && - git cat-file blob `echo 1|git hash-object --stdin` >/dev/null + git cat-file blob $(echo 1|git hash-object --stdin) >/dev/null ) ' test_done |