diff options
author | Jeff King <peff@peff.net> | 2015-05-20 14:01:32 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-05-20 13:47:30 -0700 |
commit | d6cc2df5c80dc4f52a56679baa5e32539eb028b1 (patch) | |
tree | 14ef08830713ebc424ea56bb8abfcb99602120ce /t/t5518-fetch-exit-status.sh | |
parent | Git 2.2.2 (diff) | |
download | tgif-d6cc2df5c80dc4f52a56679baa5e32539eb028b1.tar.xz |
stash: complain about unknown flags
The option parser for git-stash stuffs unknown flags into
the $FLAGS variable, where they can be accessed by the
individual commands. However, most commands do not even look
at these extra flags, leading to unexpected results like
this:
$ git stash drop --help
Dropped refs/stash@{0} (e6cf6d80faf92bb7828f7b60c47fc61c03bd30a1)
We should notice the extra flags and bail. Rather than
annotate each command to reject a non-empty $FLAGS variable,
we can notice that "stash show" is the only command that
actually _wants_ arbitrary flags. So we switch the default
mode to reject unknown flags, and let stash_show() opt into
the feature.
Reported-by: Vincent Legoll <vincent.legoll@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5518-fetch-exit-status.sh')
0 files changed, 0 insertions, 0 deletions